fix: add review tests and fix coverage thresholds#15
Merged
Conversation
…age config
- Add tests for getReviewStats() (verdicts, avgFindings, thisWeek)
- Add tests for getReviews() pagination ({limit, offset}, newest-first)
- Exclude browser-only and vendored files from coverage collection:
dashboard-client.js, htmx.min.js, idiomorph-ext.min.js
(these ran at 0% and dragged global averages below thresholds)
Coverage now passes all thresholds: lines 90.5%, branches 84.3%, functions 92.1%
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Solo org — requiring 1 approving review blocks all PRs since you can't approve your own. Temper was re-applying this rule on every sync. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getReviewStats()andgetReviews()pagination — covers all new code from feat: AI Reviews tab — stats banner + compact table + detail drawers #14dashboard-client.js) and vendored (htmx.min.js,idiomorph-ext.min.js) files from coverage collection — these ran at 0% in Node and dragged global averages below thresholdsCoverage
Test plan
npm test -- --coveragepasses all thresholds locally🤖 Generated with Claude Code