Bump rules_rust to 0.70.0 and rules_wasm_component to 1.0.0#20
Merged
Conversation
avrabe
added a commit
that referenced
this pull request
May 23, 2026
Adds fetch-depth: 0 to every cross-repo checkout in ci.yml + refreshes the (now-orphaned) relay and rivet pins to current main. Stops the rivet-validate auth flake recurring on every sibling force-push. Unblocks #20.
rules_rocq_rust (added in #17) calls rust_toolchain with `channel`, `iso_date`, and `version` attributes — newer-rules_rust APIs that wohl's pinned rules_rust commit (6281d27 via git_override) does not have. This blocks PR #19's Verus CI job at toolchain resolution. Match relay's pin: - bazel_dep rules_rust 0.61.0 -> 0.70.0 (from BCR) - drop the git_override to 6281d27 — that commit is now an ancestor of 0.70.0; the override was the old workaround for a Bazel API break that 0.61.0 had inherited (relay's MODULE.bazel comment documents this). - bazel_dep rules_wasm_component 0.1.0 -> 1.0.0 — rules_wasm_ component 1.0.0 also targets rules_rust 0.70.0; keep the local_ path_override so active rules_wasm_component dev still works. Validation - `bazel mod show_repo @rules_rust` resolves 0.70.0 from BCR cleanly. - `bazel mod show_repo @rules_wasm_component` resolves via the local override. - Existing CI (lint/test/kani/fuzz/rivet-validate) is cargo-based and does not exercise the bazel rules — so this PR's CI passes "trivially". The real bazel-side validation comes via PR #19's Verus job once rebased onto this. A future bazel build //:all CI job (tracked in #14 / #8) will be the standing gate for any rules_wasm_component API ripple through wohl's WASM components. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
c30b997 to
5daf69a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Match relay's Bazel pins so wohl can actually use the
rules_rocq_rustdep added in #17. Unblocks PR #19 (Verus CI job).Why
rules_rocq_rust(inMODULE.bazelsince #17) callsrust_toolchain(channel=..., iso_date=..., version=...), which are attributes added in newerrules_rust. wohl's pinnedrules_rustcommit (6281d27viagit_override) predates those attributes — every Bazel job that resolves the rocq toolchain fails analysis with:This is the next layer of the cascade after the nix-install fix landed in #19. Per the architect's call, this bump lands as its own PR.
Changes
bazel_dep rules_rust 0.61.0 → 0.70.0(from BCR).git_overrideforrules_rust(commit6281d27is now an ancestor of0.70.0— the override was a workaround for an older Bazel API break, no longer needed; relay'sMODULE.bazelcomment documents this).bazel_dep rules_wasm_component 0.1.0 → 1.0.0(matches relay; targets the samerules_rust 0.70.0).local_path_overrideforrules_wasm_componentretained (active local dev).Verification limits — read carefully
bazel mod show_repo @rules_rustresolves0.70.0from BCR cleanly.bazel mod show_repo @rules_wasm_componentresolves via the local override. Module-graph level is healthy.bazel build //:alllocally to verify the WASM components still build underrules_wasm_component 1.0.0— therules_rocq_rustcascade requiresnix-build(deliberate, per Pin CI sibling checkouts; add rules_rocq_rust (e4660cc) #17), and this dev Mac doesn't have nix installed. So a rule-API ripple through wohl'srust_wasm_component_bindgentargets cannot be ruled out locally.bazel build //:allCI job (tracked in WASM component build hygiene: no .bazelignore + wasm_component.rs escapes the CI lint gate #14 / CI follow-ups: matrix split, pinned siblings, cargo-deny, bazel build, nightly long-fuzz #8) would catch any WASM-build ripple in future PRs.If anything ripples, the iteration shape is the same as PR #19's: fix forward in this branch (or a child PR), with the architect's input on any non-trivial design choice.
🤖 Generated with Claude Code