Skip to content

Conversation

@ellismg
Copy link
Contributor

@ellismg ellismg commented Jun 7, 2019

No description provided.

@ellismg ellismg requested review from justinvp and metral June 7, 2019 00:19
Copy link
Contributor

@metral metral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - should we mark that v0.17.15 has errors so users skip it?

@ellismg
Copy link
Contributor Author

ellismg commented Jun 7, 2019

LGTM - should we mark that v0.17.15 has errors so users skip it?

Not sure - On the one hand, that's a decent idea. On the other hand, we've had a few of these "we really should have not released this build because it had a bad bug, let's just cut a new build with the fix and move forward" and we don't try to call these things out explicitly. I'd rather just funnel folks into the latest version regardless of the changes we make.

@metral
Copy link
Contributor

metral commented Jun 7, 2019

SGTM 👍

Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.

Co-Authored-By: Justin Van Patten <jvp@justinvp.com>
Copy link

@pulumi pulumi bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍹 The Update (preview) for stack pulumi/pulumi.io/pulumi.io-staging was successful.

Resource Changes

    Name                            Type                              Operation
~   latest-version                  aws:s3/bucketObject:BucketObject  update
~   quickstart/install/index.html   aws:s3/bucketObject:BucketObject  update
~   reference/changelog/index.html  aws:s3/bucketObject:BucketObject  update
~   search-index.json               aws:s3/bucketObject:BucketObject  update

@ellismg ellismg merged commit d1bff90 into master Jun 7, 2019
@pulumi-bot pulumi-bot deleted the ellismg/0-17-16 branch June 7, 2019 01:00
metral pushed a commit that referenced this pull request Jun 7, 2019
@justinvp justinvp mentioned this pull request Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants