-
Notifications
You must be signed in to change notification settings - Fork 258
Revamped TF vs. Pulumi IaC page #14817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 🔧 **Terraform** | ||
|
|
||
| ## Get Started with Pulumi | ||
| - ❌ Proprietary domain specific language (HCL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feedback from Eric: let's not use ANY EMOJIS in our content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's a better way of communicating this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. Emojis were in the variant page, so I pulled them into this one. Happy to get rid of them if that's our standard. Perhaps that should be in the style guide?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call; here's the PR for the style guide: #14833
Co-authored-by: asaf <69985318+asafashirov@users.noreply.github.com>
Co-authored-by: asaf <69985318+asafashirov@users.noreply.github.com>
Co-authored-by: asaf <69985318+asafashirov@users.noreply.github.com>
Co-authored-by: asaf <69985318+asafashirov@users.noreply.github.com>
Co-authored-by: asaf <69985318+asafashirov@users.noreply.github.com>
Co-authored-by: asaf <69985318+asafashirov@users.noreply.github.com>
Co-authored-by: asaf <69985318+asafashirov@users.noreply.github.com>
Co-authored-by: Eric Rudder <ericrudder@users.noreply.github.com>
asafashirov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
my only concern is potentially dropping for "pulumi vs terraform" search queries; but if that does happen, it should be temporary because google will eventually understand the company >< product entity relationship.
thoward
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! We really appreciate the contribution.
* revamped TF vs. pulumi IaC page * Update content/docs/iac/concepts/vs/terraform/_index.md Co-authored-by: asaf <69985318+asafashirov@users.noreply.github.com> * Update content/docs/iac/concepts/vs/terraform/_index.md Co-authored-by: asaf <69985318+asafashirov@users.noreply.github.com> * Update content/docs/iac/concepts/vs/terraform/_index.md Co-authored-by: asaf <69985318+asafashirov@users.noreply.github.com> * Update content/docs/iac/concepts/vs/terraform/_index.md Co-authored-by: asaf <69985318+asafashirov@users.noreply.github.com> * Update content/docs/iac/concepts/vs/terraform/_index.md Co-authored-by: asaf <69985318+asafashirov@users.noreply.github.com> * Update content/docs/iac/concepts/vs/terraform/_index.md Co-authored-by: asaf <69985318+asafashirov@users.noreply.github.com> * Update content/docs/iac/concepts/vs/terraform/_index.md Co-authored-by: asaf <69985318+asafashirov@users.noreply.github.com> * Update content/docs/iac/concepts/vs/terraform/_index.md Co-authored-by: Eric Rudder <ericrudder@users.noreply.github.com> * Incorporates reviewer feedback [pull 14817] --------- Co-authored-by: asaf <69985318+asafashirov@users.noreply.github.com> Co-authored-by: Eric Rudder <ericrudder@users.noreply.github.com>
Proposed changes
This revamp does the following:
This page will be used in upcoming Pulumi vs. Terraform campaigns and this PR lays the groundwork for its content.
As discussed @thoward , I'm finding an appropriate reviewer and will tag them in when ready.