-
Notifications
You must be signed in to change notification settings - Fork 255
Clarify OIDC vs. client secret auth guidance in Azure Insights docs #16329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This change addresses issue #15812 by clarifying the authentication options for configuring Pulumi Insights with Azure in the "Before You Begin" guide. Root cause: - The Azure section claimed to use OIDC but then described client secret authentication, which was confusing for users - The documentation didn't clearly distinguish between the two auth methods or explain when to use each Changes: - Replaced misleading instructions with clear guidance that presents both authentication options upfront - Added explicit recommendation to use OIDC for best practices (passwordless, more secure, no long-lived credentials) - Provided correct OIDC ESC configuration example (not client secret) - Added note directing users to comprehensive accounts documentation for complete step-by-step instructions on both auth methods - Ensures consistency with how AWS section references detailed guides Benefits: - Users understand OIDC is recommended for Azure authentication - Clear distinction between OIDC and client secret authentication - No more misleading instructions claiming to use OIDC while showing secrets - Directs users to comprehensive documentation for complete setup steps Fixes #15812 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Documentation ReviewThis PR successfully addresses the confusion between OIDC and client secret authentication for Azure in the Pulumi Insights documentation. The changes are clear, accurate, and well-structured. ✅ Strengths
✅ No Issues FoundAll content meets the repository's style guidelines:
✅ Technical Accuracy
Status: ✅ Approved - No changes needed. This PR is ready to merge. Mention me ('@claude') if you'd like additional reviews or have questions about any feedback. |
|
Your site preview for commit 6f04e8f is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16329-6f04e8f3.s3-website.us-west-2.amazonaws.com. |
jkodroff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't vouch for the technical correctness of the content, but the formatting and verbiage looks fine.
|
Your site preview for commit 028b70e is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16329-028b70e1.s3-website.us-west-2.amazonaws.com. |
Summary
This PR clarifies the authentication options for configuring Pulumi Insights with Azure, addressing confusion where the documentation claimed to use OIDC but actually described client secret authentication.
Changes
File Modified:
What Changed:
oidc: trueand proper environment variablesRoot Cause
The original documentation:
clientSecret, not OIDC (lines 114-131)This mismatch confused users who expected OIDC instructions but got client secret setup instead.
Solution
The new documentation:
Benefits
Testing
make lint- All checks passedmake build- Site builds successfully/docs/insights/discovery/accounts/#azureverifiedFixes
Closes #15812
🤖 Generated with Claude Code