Skip to content

Conversation

@SaraDPH
Copy link
Contributor

@SaraDPH SaraDPH commented Oct 24, 2025

Proposed changes

Unreleased product version (optional)

Related issues (optional)

@SaraDPH SaraDPH self-assigned this Oct 24, 2025
@claude
Copy link
Contributor

claude bot commented Oct 24, 2025

Review Summary

This PR successfully updates the workshop from a gated, upcoming event to an ungated, on-demand recording. The changes look good overall with minor observations below.

✅ What's Good

  • Correctly updated gated: false to remove registration requirement
  • Added YouTube embed URL for on-demand viewing
  • Duration updated to match the actual recording length
  • Topics expanded to be more comprehensive and discoverable

📝 Observations

Line 41: The date sortable_date: 2025-10-14T12:00:00-04:00 is set to October 2025 (future date). For on-demand content, this will sort the workshop as if it hasn't happened yet. Consider whether this should be:

  • The original workshop date (if it already occurred)
  • Today's date (if making it available now)
  • An intentional future date (if scheduling the on-demand release)

Lines 79-80: Similar concern with the event_data dates showing future dates in October 2025.

Line 44: Duration is now 60 minutes. Verify this matches the actual YouTube video length to set proper user expectations.

🔍 Unable to Verify

  • YouTube URL accessibility (CI environment limitation) - recommend manually verifying the embed URL works correctly
  • Whether the video content matches the updated topic tags

✨ Style & Standards

All changes comply with:

  • ✅ YAML frontmatter formatting
  • ✅ File ends with newline
  • ✅ Consistent spacing and indentation
  • ✅ No spelling or grammar issues

Next Steps: If the date concerns apply, please update the sortable_date and event_data dates to reflect the correct timeline for this on-demand content.

Mention @claude if you'd like me to review any updates or need assistance with fixes.

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

- Add quotes to URL in learn section to fix YAML parsing
- Remove invisible Unicode character from meta_image field
@dirien dirien force-pushed the Pulumi-Neo-workshop-on-demand branch from cb3910a to 26b733c Compare October 24, 2025 16:01
@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@SaraDPH
Copy link
Contributor Author

SaraDPH commented Oct 24, 2025

@CamSoper @kimberleyamackenzie, do the workshop templates not allow URLs in the 'You'll' section and the description field? Is there a way to add them, especially if they are resources for the on-demand workshops?

@kimberleyamackenzie
Copy link
Contributor

@SaraDPH I don't believe the event template parses anything but strings as it currently is set up in that section. We could add a field to support this, but my team won't be able to take that on until mid-November - it's probably pretty small, but we are swamped with product and feature work at the moment.

@SaraDPH
Copy link
Contributor Author

SaraDPH commented Oct 24, 2025

@SaraDPH I don't believe the event template parses anything but strings as it currently is set up in that section. We could add a field to support this, but my team won't be able to take that on until mid-November - it's probably pretty small, but we are swamped with product and feature work at the moment.

@kimberleyamackenzie I added an issue to add a resources area for on-demand. It isn't urgent, we can add it later. https://github.com/pulumi/marketing/issues/1539

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@SaraDPH SaraDPH merged commit 6809da9 into master Oct 24, 2025
11 checks passed
@SaraDPH SaraDPH deleted the Pulumi-Neo-workshop-on-demand branch October 24, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants