-
Notifications
You must be signed in to change notification settings - Fork 255
Add tom king profile #16405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tom king profile #16405
Conversation
Review FindingsThank you for adding Tom King's profile! I've reviewed the changes and found one issue that needs to be addressed: Issues FoundMissing newline at end of file (data/team/team/tom-king.toml:10) The file must end with a newline character. According to AGENTS.md, "Markdown: Must always end with a newline." This applies to all text files in the repository. Suggested Fix(Add a blank line after the last line) Format ObservationsThe file structure looks good overall and follows the existing team profile format. I noticed:
Note on Social FieldsThe file uses "bluesky" as a social field. This appears to be a new platform addition that other profiles don't have yet. Please verify this is supported by the Hugo templates that render these team profiles. Once the newline issue is fixed, this PR will be ready to merge. Let me know if you'd like me to make the fix, or mention @claude if you need additional reviews or assistance. |
|
Your site preview for commit bfece80 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16405-bfece80a.s3-website.us-west-2.amazonaws.com. |
|
Your site preview for commit 0ee8ec1 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16405-0ee8ec1e.s3-website.us-west-2.amazonaws.com. |
|
Your site preview for commit f129cb3 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16405-f129cb3c.s3-website.us-west-2.amazonaws.com. |
CamSoper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, let's ![]()
|
Your site preview for commit e86391c is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16405-e86391c8.s3-website.us-west-2.amazonaws.com. |
Proposed changes
Add Tom King to the team docs.