-
Notifications
You must be signed in to change notification settings - Fork 255
Add ESC terraform-state provider docs #16419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Documentation ReviewThank you for adding the terraform-state provider documentation! Overall, this is well-structured and follows the repository conventions. I found a few minor issues that should be addressed: Issues Found1. Missing Newline at End of File (Line 95)The file Fix: Add a newline at the end of the file. 2. Table Formatting: Optional Properties Not Marked (Lines 80-84)In the "Remote" backend table, the Suggestion: | Property | Type | Description |
|----------------|--------|-------------------------------------------------------------|
| `hostname` | string | [Optional] - The hostname of Terraform Cloud/Enterprise. Defaults to `app.terraform.io`. |
| `organization` | string | The Terraform Cloud organization name. |
| `workspace` | string | The workspace name. |
| `token` | string | The Terraform Cloud API token. |Then you can remove the separate note: "The 3. Consistency: "Terraform Cloud/Enterprise" vs "Terraform Cloud" (Line 81)The hostname description mentions "Terraform Cloud/Enterprise" but the organization and workspace descriptions only mention "Terraform Cloud". For consistency, either use "Terraform Cloud/Enterprise" throughout or clarify which properties apply to both. Positive Observations✓ Proper use of aliases for SEO preservation Action RequiredPlease address the three issues above, particularly #1 (missing newline) which is a strict requirement per AGENTS.md. If you'd like me to review the changes after you've made updates, or if you need help implementing any of these suggestions, mention me (@claude) in a comment. |
|
Your site preview for commit 7c885f2 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16419-7c885f2c.s3-website.us-west-2.amazonaws.com. |
Documentation ReviewThank you for adding documentation for the ESC terraform-state provider! This is a well-structured addition. I found a few items to address: Issues Foundterraform-state.md:82 - Inconsistent optional formatting
terraform-state.md:19 - Section heading case
terraform-state.md:1-13 - Missing h1 field
terraform-state.md:93 - Missing trailing newline
Positive Notes
Recommendations
Once you've addressed these items, feel free to mention me (@claude) if you'd like another review or have questions! |
fnune
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
content/docs/esc/integrations/infrastructure/terraform/terraform-state.md
Show resolved
Hide resolved
content/docs/esc/integrations/infrastructure/terraform/terraform-state.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Fausto Núñez Alberro <fausto.nunez@mailbox.org>
|
Your site preview for commit 9f2b8b9 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16419-9f2b8b93.s3-website.us-west-2.amazonaws.com. |
Proposed changes
The esc terraform-state provider enables importing outputs from a terraform state file into an environment.
This is the equivalent of the pulumi-stacks provider for terraform.
Related issues (optional)