-
Notifications
You must be signed in to change notification settings - Fork 258
update docs for create/update insights accounts api #16613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Documentation ReviewThanks for updating the API reference documentation! The changes accurately reflect the parameter updates from Issues FoundLine 39: Inconsistent spacing in parameter description Line 88: Same spacing issue in Update Account section Style Observations
Content Accuracy
Overall, this is a solid update to the API documentation. The changes are clear and well-structured. Mention me (@claude) if you'd like additional reviews or fixes applied. |
|
Your site preview for commit 879e371 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16613-879e3715.s3-website.us-west-2.amazonaws.com. |
Documentation ReviewI've reviewed the changes to the Insights Accounts API documentation. The updates are clear and accurate, with just a few minor issues to address: Issues FoundLine 23: Missing period at end of list item The new bullet point is missing a period at the end for consistency with the other list items. Line 39: Inconsistent trailing spaces in table description The table cell descriptions should have consistent spacing. The current line has extra trailing spaces after "daily". Line 84: Same spacing issue in Update Account table Same trailing space issue in the Update Account parameters table. Line 112: Missing period at end of sentence The last sentence in the file is missing a period. Positive Notes
RecommendationThe changes are well-structured and ready to merge after fixing the minor punctuation and spacing issues noted above. Mention @claude if you'd like me to review any additional changes or help with fixes. |
|
Your site preview for commit 74270f0 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16613-74270f01.s3-website.us-west-2.amazonaws.com. |
Proposed changes
Update API reference to reflect recent changes to the Insights Accounts Create and Update API endpoints
Related issues (optional)
https://github.com/pulumi/pulumi-service/issues/34822