-
Notifications
You must be signed in to change notification settings - Fork 258
aws-organizations tag policies #16621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Documentation ReviewI have reviewed PR #16621 introducing the AWS Organizations Tag Policies integration. Critical IssueBlog Post - Line 30: Broken internal link The link is missing a leading slash:
Other IssuesPR Description: Contains typo poilcy should be policy Documentation - Line 22: Consider clarifying enforcement modes upfront since the pack supports both advisory and mandatory modes. Style ComplianceAll style guidelines are followed correctly:
Content QualityStrengths:
SummaryThis is excellent work with comprehensive documentation. Only one CRITICAL issue: the broken link on line 30 of the blog post. Action required:
Overall, the documentation is thorough, well-organized, and follows Pulumi style guidelines effectively. If you need help with fixes or want additional review, mention @claude in a comment. |
|
Your site preview for commit ec61df3 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16621-ec61df3d.s3-website.us-west-2.amazonaws.com. |
ec61df3 to
9f2e9f6
Compare
|
Your site preview for commit 9f2e9f6 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16621-9f2e9f64.s3-website.us-west-2.amazonaws.com. |
|
Your site preview for commit 5e3417a is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16621-5e3417a3.s3-website.us-west-2.amazonaws.com. |
|
Your site preview for commit 4483c93 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16621-4483c93c.s3-website.us-west-2.amazonaws.com. |
| @@ -0,0 +1,55 @@ | |||
| --- | |||
| title: "Enforce AWS Organizations Tag Policies with Pulumi" | |||
| date: 2025-11-21T00:00:03-08:00 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can change this back to 11-20
|
Your site preview for commit 006d9e2 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16621-006d9e29.s3-website.us-west-2.amazonaws.com. |
|
Your site preview for commit cce9f83 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16621-cce9f836.s3-website.us-west-2.amazonaws.com. |
Releasing new docs and blog post about the new built-in poilcy pack built in partnership with AWS