Skip to content

Conversation

@aacotroneo
Copy link
Contributor

Releasing new docs and blog post about the new built-in poilcy pack built in partnership with AWS

@claude
Copy link
Contributor

claude bot commented Nov 20, 2025

Documentation Review

I have reviewed PR #16621 introducing the AWS Organizations Tag Policies integration.

Critical Issue

Blog Post - Line 30: Broken internal link

The link is missing a leading slash:

Other Issues

PR Description: Contains typo poilcy should be policy

Documentation - Line 22: Consider clarifying enforcement modes upfront since the pack supports both advisory and mandatory modes.

Style Compliance

All style guidelines are followed correctly:

  • Headings use proper case (H1 Title Case, H2+ Sentence case)
  • Lists use 1. notation
  • Product names properly capitalized
  • Terminology consistent throughout

Content Quality

Strengths:

  • Clear, concise writing
  • Strong opening hook addressing real pain points
  • Comprehensive technical documentation
  • Excellent resource mapping table (440+ lines of AWS to Pulumi mappings)
  • Good step-by-step instructions
  • Partnership with AWS well-highlighted

Summary

This is excellent work with comprehensive documentation. Only one CRITICAL issue: the broken link on line 30 of the blog post.

Action required:

  1. Fix broken link on line 30 (add leading slash)
  2. Optional: Fix typo in PR description
  3. Optional: Consider clarity improvement for line 22 of integration docs

Overall, the documentation is thorough, well-organized, and follows Pulumi style guidelines effectively.


If you need help with fixes or want additional review, mention @claude in a comment.

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@@ -0,0 +1,55 @@
---
title: "Enforce AWS Organizations Tag Policies with Pulumi"
date: 2025-11-21T00:00:03-08:00
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can change this back to 11-20

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@fallimic fallimic merged commit 7a53a5f into master Nov 20, 2025
7 of 8 checks passed
@fallimic fallimic deleted the aa/aws-org-tags branch November 20, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants