-
Notifications
You must be signed in to change notification settings - Fork 258
Revise AWS content for Neo branding and features #16658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated headings and descriptions to reflect new branding and features for Neo on AWS in addition to correcting inaccuracies in the original copy.
Documentation ReviewI've reviewed the changes to update the AWS partner page for Neo branding and features. Overall, the changes improve accuracy and align with the new branding. However, there are a few issues to address: Issues Found1. Missing trailing newline (line 366) The file should end with a newline character. The current last line is: 2. Grammatical issue - "End-to-end Compliance" heading (line 142) The heading "End-to-end Compliance" should follow sentence case for H2+ headings per the style guide. However, this is actually correct as-is since "end-to-end" is a compound modifier. 3. Inconsistent product naming - "Neo" vs "Pulumi Neo" (lines 127, 145, 157, 172, 178) The changes refer to "Neo" without the "Pulumi" prefix in most places. According to STYLE-GUIDE.md, product names should be capitalized correctly and expanded at first mention. Consider whether the first mention should be "Pulumi Neo" with subsequent references as "Neo". Specifically:
4. Technical accuracy check needed - AWS Bedrock AgentCore (line 130) The description states "Built on AWS Bedrock AgentCore". Please verify this is the correct AWS product name. AWS typically uses "Amazon Bedrock" and I'm not familiar with "AgentCore" as a specific Bedrock component. This may need fact-checking. 5. Hyphenation - "policy-as-code" (line 164) Line 164 uses "Policy-as-code" (capitalized) which is correct for the start of a sentence, but it should be consistently hyphenated throughout. Strengths
Recommendations
If you'd like me to review additional changes or help implement any fixes, mention @claude and I'll assist. |
|
Your site preview for commit 8483b3e is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16658-8483b3ed.s3-website.us-west-2.amazonaws.com. |
fixing to match other cards
fixing branding
edit for consistency
|
Your site preview for commit e1c9632 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16658-e1c9632e.s3-website.us-west-2.amazonaws.com. |
|
Your site preview for commit c9818d6 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16658-c9818d64.s3-website.us-west-2.amazonaws.com. |
|
Your site preview for commit 7c7c273 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16658-7c7c2731.s3-website.us-west-2.amazonaws.com. |
isaac-pulumi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edit for brevity
|
Your site preview for commit 3a0af56 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16658-3a0af565.s3-website.us-west-2.amazonaws.com. |
Updated headings and descriptions to reflect new branding and features for Neo on AWS in addition to correcting inaccuracies in the original copy.
Proposed changes
The original version was not accurate and was missing key points.