Skip to content

Move apply.md nested output values inline code to static programs#18331

Merged
jkodroff merged 3 commits intomasterfrom
jk/move-apply-inline-to-programs
Apr 1, 2026
Merged

Move apply.md nested output values inline code to static programs#18331
jkodroff merged 3 commits intomasterfrom
jk/move-apply-inline-to-programs

Conversation

@jkodroff
Copy link
Copy Markdown
Member

@jkodroff jkodroff commented Apr 1, 2026

Consolidate the "Accessing nested output values" section's inline code into testable static programs (apply-nested-output-values-{lang}), and rename "Accessing single output values" to "Printing output values".

Closes #18170

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Apr 1, 2026

Docs Review

Critical Issue

Committed binary file: static/programs/apply-nested-output-values-go/apply-nested-output-values-go is a 34 MB compiled Mach-O arm64 executable that was accidentally committed. This should be removed from the PR. Consider adding it to .gitignore or the Go program's local ignore rules.

Minor Issues

  1. C# lifting snippet includes outer scope closure (apply.md, snippet from="28" to="37"): Line 37 of Program.cs is }); which closes the outer Deployment.RunAsync lambda, not the Record constructor. The rendered snippet will show an extra unrelated closing brace. Consider using from="28" to="36" instead to end at the Record's closing });.

  2. Java program only includes the apply pattern: All other languages (TypeScript, Python, Go, C#) demonstrate both apply and lifting patterns. The Java program only shows apply. This is consistent with the existing doc text that says Java doesn't support lifting yet, but worth noting for completeness — if Java lifting support has been added since the original text was written, this would be a good time to update.

Looks Good

  • Snippet line ranges are correct and match the source files for all languages.
  • All static programs have complete project structure (Pulumi.yaml, dependency files, source files).
  • The heading rename from "Accessing single output values" to "Printing output values" is reflected consistently in both the heading and the internal anchor link reference at line 23.
  • Code examples use correct idiomatic patterns per language (snake_case for Python, PascalCase for C#, camelCase for TypeScript/Java).
  • Import statements are correct across all languages (@pulumi/aws, pulumi_aws, Pulumi.Aws.*, etc.).
  • YAML program correctly only shows lifting (YAML handles inputs/outputs transparently).

Mention @claude if you'd like additional reviews or fixes.

Consolidate the "Accessing nested output values" section's inline code
into testable static programs (apply-nested-output-values-{lang}), and
rename "Accessing single output values" to "Printing output values".

Closes #18170

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jkodroff jkodroff force-pushed the jk/move-apply-inline-to-programs branch from 0aa1a85 to b251edf Compare April 1, 2026 22:49
@pulumi-bot
Copy link
Copy Markdown
Collaborator

@pulumi-bot
Copy link
Copy Markdown
Collaborator

- H3 heading "Outputs and Strings" → "Outputs and strings" (sentence case)
- Remove duplicate "yaml" in chooser declaration

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

@CamSoper CamSoper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Clean move of inline code to testable static programs — all snippet line ranges verified against source files, code reviewed across all six languages.

I also fixed two pre-existing style nits:

  • H3 "Outputs and Strings" → "Outputs and strings" (sentence case)
  • Removed duplicate yaml in a chooser declaration

Ship it! 🚀

@pulumi-bot
Copy link
Copy Markdown
Collaborator

RecordArgs.type() expects Either<String, RecordType>, not a plain String.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@pulumi-bot
Copy link
Copy Markdown
Collaborator

@jkodroff jkodroff merged commit a3cee9f into master Apr 1, 2026
7 checks passed
@jkodroff jkodroff deleted the jk/move-apply-inline-to-programs branch April 1, 2026 23:34
CamSoper added a commit to CamSoper/pulumi.docs that referenced this pull request May 5, 2026
CamSoper added a commit to CamSoper/pulumi.docs that referenced this pull request May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move inputs/outputs apply page (apply.md) inline code to static/programs

3 participants