Conversation
Docs Review — PR #18524Scope: Blog post ( Overall this is a well-structured PR. The blog post is clear and concise, the docs page is thorough with good use of tables and shortcodes, and the Issues1. Social media copy is empty (blog The (Suggestion is illustrative — please fill in platform-appropriate copy before merging.) 2. The SVG file doesn't end with a newline character. New files should end with a trailing newline. Publishing readiness checklist (blog)
Docs page notes
Mention @claude in a comment if you'd like additional reviews or automated fixes. |
Social Media Reviewcontent/blog/connect-any-git-server-to-pulumi-deployments-with-custom-vcs/index.mdX — missingLinkedIn — missingBluesky — missingNo social copy found for any platform. Suggested copy below — all three passed critique. Suggested copyX (222/255 chars):
LinkedIn (586/2950 chars):
Bluesky (259/300 chars):
To apply these suggestions, comment: To re-run the social media review after updates, comment: |
|
Your site preview for commit bbae8f3 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-18524-bbae8f3c.s3-website.us-west-2.amazonaws.com |
Lighthouse Performance ReportCommit: bbae8f3 | Metric definitions
|
bc48675 to
bbae8f3
Compare
Social Media Reviewcontent/blog/connect-any-git-server-to-pulumi-deployments-with-custom-vcs/index.mdX — missingLinkedIn — missingBluesky — missingNo social copy found for any platform. Suggested copy below — all three passed critique. Suggested copyX (240/255 chars):
LinkedIn (665/2950 chars):
Bluesky (288/300 chars):
To apply these suggestions, comment: To re-run the social media review after updates, comment: |
Social Media Reviewcontent/blog/connect-any-git-server-to-pulumi-deployments-with-custom-vcs/index.mdX — missingLinkedIn — missingBluesky — missingNo social copy was found for any platform. Suggested copy below. Suggested copyX (227/255 chars):
LinkedIn (580/2950 chars):
Bluesky (274/300 chars):
To apply these suggestions, comment: To re-run the social media review after updates, comment: |
Docs ReviewPR adds documentation and a launch blog post for Custom VCS -- a new Pulumi Cloud integration for connecting any Git or Mercurial VCS to Pulumi Deployments. Overall this is well-written, clearly structured, and technically thorough. A few items to address before merging: Issues1. Blog URL slug does not match title (SEO) The blog title is Connect Any Git or Mercurial Repo to Pulumi with Custom VCS but the directory slug is 2. Social media copy is empty ( The 3. The SVG file is missing a trailing newline. Per the review criteria, all new files should end with a newline. 4. Terminology inconsistency in troubleshooting table ( The troubleshooting table says "deploy on push" but the Deployment settings table on line 156 calls it "Push to deploy". These should use the same label to avoid confusion. 5. Blog post has no CTA The blog ends with a "Learn more" links section, which is fine, but there is no call-to-action button using the Minor / Optional
What looks good
Publishing readiness checklist (blog)
Mention me ( |
There was a problem hiding this comment.
Reviewed the docs and blog for the Custom VCS launch. Verified the webhook URL, headers (X-Generic-VCS-Integration-ID, X-Generic-VCS-Signature), HMAC v1= signing scheme, payload fields, and ESC credential keys against pulumi/pulumi-service (cmd/service/vcs/generic/webhook.go, source_context.go). Internal cross-references and the #push-to-deploy anchor all resolve. Style and structure are clean.
LGTM!
|
Waiting o
Waiting on some other PRs to land before launch. Will get this branch update again. |
Proposed changes
Adds documentation and a launch blog post for Custom VCS — a new Pulumi Cloud integration that connects any Git-based version control system (self-hosted or third-party) to Pulumi Deployments using webhooks and ESC-managed credentials.
Unreleased product version (optional)
Related issues (optional)
Feature implemented in pulumi/pulumi-service (PR #41027 and related backend PRs)