Style updates. Change main fonts to Roboto and Roboto Mono#24
Style updates. Change main fonts to Roboto and Roboto Mono#24chrsmith merged 1 commit intopulumi:masterfrom lindydonna:style-changes
Conversation
|
👍 on both visual improvements here. |
|
Definitely an improvement. Should we make similar changes to our other sites? I actually did something similar in my latest frontend update. /cc @chrsmith |
|
If we want to standardize on Roboto { Mono } I'm happy to wire the change to our stealth-homepage and Pulumi Console apps. Though if we are converging on an actual UX standard of sorts, I should do the work I've been putting off and creating a reusable CSS library we can use for all the sites. I know it sounds like overkill, but @joeduffy what do you think about creating a Alternatively we could just build the CSS library in the |
|
@chrsmith Do you mind merging this PR and doing a new docs release? |
|
I'd be happy to. Just about to leave to pick up my kids, but I'll try to get to it tonight. |
|
@lindydonna I pushed your changes, @joeduffy I updated the live site with your spelling error changes too. |
|
@chrsmith There are other weird visual artifacts related to some antialiasing. For example:
and
They almost look like they have shadows underneath them. I think these are related to the Do other folks see this? Any idea what to do? |
|
i do see this, and i've shown chris ... i can share tomorrow on my monitor
if you don't see on yours for some reason. i see this on both windows and
android
…On Sun, Nov 19, 2017 at 11:57 AM, Joe Duffy ***@***.***> wrote:
@chrsmith <https://github.com/chrsmith> There are other weird visual
artifacts related to some antialiasing.
For example:
[image: image]
<https://user-images.githubusercontent.com/3953235/32994751-97fa89ee-cd20-11e7-9851-c4da4b34cec7.png>
and
[image: image]
<https://user-images.githubusercontent.com/3953235/32994753-9f6317a0-cd20-11e7-8d81-8924413a2796.png>
They almost look like they have shadows underneath them. I think these are
related to the -webkit-font-smoothing: antialiased CSS, but am not sure.
Do other folks see this? Any idea what to do?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#24 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AH_5wiopIMC7Kn8MaSuzEQExcXIBjvbOks5s4IhBgaJpZM4Qh7Z->
.
|
The script is the sole writer of <!-- CLAUDE_REVIEW N/M --> markers.
On re-entrant runs, Sonnet sometimes copies the previous pinned body
verbatim into its output (marker and all), and render_with_markers
then prepends a second marker on top of the stale one. The pinned
comment ends up with two markers stacked at the top.
Fix split_body to drop any inbound marker line via an awk guard:
/^<!-- CLAUDE_REVIEW [0-9]+\/[0-9]+ -->[[:space:]]*$/ { next }
The render_with_markers step still prepends exactly one fresh marker
per page, so the output shape is unchanged for well-behaved input
and self-healing for stale input.
Caught during fork-based force-push re-entrant test on PR #24.
5 participants
I find the current body and monospace font hard to read. I also removed the horizontal lines, as they are just visual noise.
Screenshot of changes: