[CX-2682, CX-2683, CX-2684] - Move all configuration/secrets to AWS Secret Manager#2
Merged
mahendra-kathirvel merged 6 commits intomainfrom Apr 11, 2025
Merged
Conversation
mahendra-kathirvel
requested changes
Apr 2, 2025
| @@ -0,0 +1,27 @@ | |||
| # Build the application from source | |||
| FROM golang:1.24 AS build-stage | |||
There was a problem hiding this comment.
Lets set a specific version of go ie. 1.24.2
| RUN CGO_ENABLED=0 GOOS=linux go build -o /server main.go | ||
|
|
||
| # Deploy the application binary into a lean image | ||
| FROM alpine:3.14 AS build-release-stage |
There was a problem hiding this comment.
See if we have the latest release of alpine 3.21
| if k == "db_port" { | ||
| u64, _ := strconv.ParseUint(v.(string), 10, 32) | ||
| dbObj.Port = uint(u64) | ||
| // dbobj.Port = uint(u64) |
There was a problem hiding this comment.
Suggested change
| // dbobj.Port = uint(u64) | |
| // dbobj.Port = uint(u64) | |
remove this
| @@ -2,7 +2,11 @@ module com.lc.go.codepush/server | |||
|
|
|||
| go 1.21.5 | |||
There was a problem hiding this comment.
Go version not matching up with the version mentioned in Dockerfile
vivekpunchh
force-pushed
the
vivek_cx_2682
branch
from
525d7ba to
3bc54e5
Compare
vivekpunchh
force-pushed
the
vivek_cx_2682
branch
from
3bc54e5 to
c1d048b
Compare
mahendra-kathirvel
requested changes
Apr 10, 2025
| COPY --from=build-stage server . | ||
|
|
||
| EXPOSE 8080 | ||
| ENTRYPOINT ["./server"] No newline at end of file |
|
|
||
| // default values | ||
| config.DBUser.MaxIdleConns = 5 | ||
| config.DBUser.MaxOpenConns = 60 |
There was a problem hiding this comment.
Reduce the connection to 20
mahendra-kathirvel
changed the title
vivekpunchh
changed the title
mahendra-kathirvel
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://punchhdev.atlassian.net/browse/CX-2682
https://punchhdev.atlassian.net/browse/CX-2684
https://punchhdev.atlassian.net/browse/CX-2683