Skip to content

bugfix: broken finding filtering#44

Merged
SimonGurney merged 1 commit intomainfrom
issue-on-filtering
Jun 12, 2025
Merged

bugfix: broken finding filtering#44
SimonGurney merged 1 commit intomainfrom
issue-on-filtering

Conversation

@SimonGurney
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Findings Summary

Critical Findings

Hardcoded Line Number Vulnerability
File: saist/main.py
Issue: The line number is hardcoded to -1 for filtering purposes, which may lead to incorrect filtering or masking of valid findings. This could result in security issues being overlooked during analysis.
Recommendation: Implement dynamic line number assignment based on the actual context of each finding to ensure accurate filtering and reporting of security issues.

Comment thread saist/main.py
all_findings.sort(key=lambda x: x.priority,reverse=True)

for item in all_findings:
item.line_number = -1 #set to -1 for filtering. Gets changed later if finding is valid
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Issue: The line number is hardcoded to -1 for filtering purposes, which may lead to incorrect filtering or masking of valid findings.

Priority: LOW

CWE: CWE-330

Recommendation: Ensure that the line number is dynamically set based on the actual context of the finding.

Snippet: item.line_number = -1 #set to -1 for filtering. Gets changed later if finding is valid

@SimonGurney SimonGurney merged commit d62b5ee into main Jun 12, 2025
2 checks passed
@SimonGurney SimonGurney deleted the issue-on-filtering branch June 12, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant