Skip to content

Fix install_puppet_on on el8#170

Merged
smortex merged 2 commits into
puppetlabs:masterfrom
gcampbell12:patch-1
Aug 31, 2021
Merged

Fix install_puppet_on on el8#170
smortex merged 2 commits into
puppetlabs:masterfrom
gcampbell12:patch-1

Conversation

@gcampbell12
Copy link
Copy Markdown
Contributor

beaker has support for an el-8-* platform but the install_puppet_on function does not recognise this platform

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 31, 2021

Codecov Report

Merging #170 (7344f33) into master (ee3b88b) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 7344f33 differs from pull request most recent head bce5987. Consider uploading reports for the commit bce5987 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
- Coverage   78.09%   78.07%   -0.03%     
==========================================
  Files          15       15              
  Lines        1598     1596       -2     
==========================================
- Hits         1248     1246       -2     
  Misses        350      350              
Impacted Files Coverage Δ
lib/beaker-puppet/install_utils/foss_utils.rb 70.93% <100.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee3b88b...bce5987. Read the comment docs.

Comment thread lib/beaker-puppet/install_utils/foss_utils.rb Outdated
@ekohl
Copy link
Copy Markdown
Contributor

ekohl commented Aug 31, 2021

@smortex want to recheck?

@smortex
Copy link
Copy Markdown
Contributor

smortex commented Aug 31, 2021

👍

@smortex smortex merged commit c8ad579 into puppetlabs:master Aug 31, 2021
@bastelfreak bastelfreak changed the title Add el8 support for install_puppet_on Fix install_puppet_on on el8 Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants