Removes deprecated network device platforms#205
Merged
ekohl merged 2 commits intoFeb 16, 2023
Conversation
Arista support was removed from puppet-agent in the 6.x series in 2018: puppetlabs/puppet-agent@6038549 This commit removes setup steps for Arista that should no longer be necessary.
Cumulus support was removed from Puppet in 2019, so setup steps and tests are no longer necessary for the platform. See https://tickets.puppetlabs.com/browse/PA-2571 for more details.
Codecov ReportBase: 78.19% // Head: 78.19% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #205 +/- ##
=======================================
Coverage 78.19% 78.19%
=======================================
Files 15 15
Lines 1605 1605
=======================================
Hits 1255 1255
Misses 350 350
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ekohl
approved these changes
Feb 16, 2023
Contributor
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
I wonder if we should also drop cumulus from beaker-hostgenerator if they're no longer used anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes support/mention of both Arista and Cumulus, two operating systems for network devices which have been deprecated by Puppet for years.
At some point we should also remove Huawei and Cisco OSes as well.