Skip to content

(maint) Pre suite paths must be relative#32

Merged
joshcooper merged 1 commit into
puppetlabs:masterfrom
melissa:maint/master/relative-paths-windows
Mar 24, 2018
Merged

(maint) Pre suite paths must be relative#32
joshcooper merged 1 commit into
puppetlabs:masterfrom
melissa:maint/master/relative-paths-windows

Conversation

@melissa
Copy link
Copy Markdown
Contributor

@melissa melissa commented Mar 23, 2018

When run with the absolute path, tests on Japanese windows end up with
an unescaped % in the path. This results in an error #<ArgumentError: malformed format string - %D>. If we ensure these paths are relative,
we should be able to avoid this failure.

When run with the absolute path, tests on Japanese windows end up with
an unescaped `%` in the path. This results in an error `#<ArgumentError:
malformed format string - %D>`. If we ensure these paths are relative,
we should be able to avoid this failure.
Copy link
Copy Markdown

@branan branan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from me

@joshcooper
Copy link
Copy Markdown
Contributor

👍

Before

14:26:41     "pre_suite": [
14:26:41         "/tmp/jenkins/workspace/platform_puppet-agent_puppet-agent-integration-suite_daily-1.10.x/COMPONENT/puppet/SLAVE_LABEL/beaker/TEST_TARGET/windows2012r2_ja-64a%7Blocale=ja%7D/acceptance/.bundle/gems/ruby/2.3.0/gems/beaker-puppet-0.11.0/setup/common/000-delete-puppet-when-none.rb",
...
14:26:41 #<ArgumentError: malformed format string - %D>
14:26:41 /tmp/jenkins/workspace/platform_puppet-agent_puppet-agent-integration-suite_daily-1.10.x/COMPONENT/puppet/SLAVE_LABEL/beaker/TEST_TARGET/windows2012r2_ja-64a%7Blocale=ja%7D/acceptance/.bundle/gems/ruby/2.3.0/bundler/gems/beaker-b629407b01c2/lib/beaker/test_suite.rb:72

After:

    "pre_suite": [
        "../../beaker-puppet/setup/common/000-delete-puppet-when-none.rb",
        "../../beaker-puppet/setup/aio/010_Install.rb",
        "../../beaker-puppet/setup/aio/020_InstallCumulusModules.rb",
        "../../beaker-puppet/setup/aio/021_InstallAristaModule.rb",
        "../../beaker-puppet/setup/common/025_StopFirewall.rb",
        "../../beaker-puppet/setup/common/030_StopSssd.rb",
        "../../beaker-puppet/setup/common/040_ValidateSignCert.rb",
        "../../beaker-puppet/setup/aio/045_EnsureMasterStarted.rb"
    ],

@joshcooper joshcooper merged commit 19fe9e6 into puppetlabs:master Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants