(PUP-9136) Ensure state is preserved between runs#72
Merged
Conversation
Contributor
Author
|
This depends on voxpupuli/beaker#1544, and may need a beaker bump once that change is merged |
Contributor
Author
|
We'll want to bump the beaker dependency in this PR as well, to ensure we use a version of beaker that supports this new flag. |
joshcooper
approved these changes
Oct 12, 2018
melissa
force-pushed
the
ticket/master/save-state
branch
from
e4a12e3 to
73bebf9
Compare
Contributor
Author
|
For those playing along, the PR Tests are currently failing with which is perfect, since beaker 4.0.1 should be released tomorrow!! I'll be sure to re-kick these tests once that's available. |
We need to be able to preserve the state of the hosts that is set up during the pre-suite runs. We previously were relying on beaker to initiate this on every invocation, but that behavior was removed in beaker 4. This commit takes advantage of a new flag that will cause invocations of `beaker exec` to save the host state. We really only want to do this when we're running pre-suites. The `--preserve-state` flag was introduced in beaker 4.1.0. If we try to run these tasks with a lower version of beaker, we'll get a failure because of an unknown option.
melissa
force-pushed
the
ticket/master/save-state
branch
from
73bebf9 to
ba30fd5
Compare
Contributor
Author
|
jenkins please test this |
Contributor
Author
|
jenkins retest this please |
Contributor
Author
|
@kevpl @ekinanp @joshcooper @jhelwig @kris-bosland the beaker 4.1.0 release having just happened, we can officially merge this. We should also cut a beaker-puppet release asap |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to be able to preserve the state of the hosts that is set up
during the pre-suite runs. We previously were relying on beaker to
initiate this on every invocation, but that behavior was removed in
beaker 4. This commit takes advantage of a new flag that will cause
invocations of
beaker execto save the host state. We really only wantto do this when we're running pre-suites.