(maint) Set server in puppet.conf in ValidateSignCert#85
Merged
mcdonaldseanp merged 1 commit intoNov 27, 2018
Merged
Conversation
Specifies the `server` setting in puppet.conf during the ValidateSignCert setup step; The puppetserver ca CLI does not have a `--server` flag like puppet does.
mcdonaldseanp
approved these changes
Nov 27, 2018
ekinanp
approved these changes
Nov 27, 2018
This was referenced Nov 27, 2018
caseywilliams
force-pushed
the
maint/server-puppet-conf
branch
from
431818f to
f5a40fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifies the
serversetting in puppet.conf during the ValidateSignCert setup step; The puppetserver ca CLI does not have a--serverflag like puppet does.This is intended to resolve failures like this one in agent acceptance: https://jenkins-master-prod-1.delivery.puppetlabs.net/view/puppet-agent/view/Acceptance%20Suites/view/6.0.x/view/Suite/job/platform_puppet-agent_puppet-agent-integration-suite_daily-6.0.x/62/RMM_COMPONENT_TO_TEST_NAME=puppet,SLAVE_LABEL=beaker,TEST_TARGET=osx1012-64a/console
Along with puppetlabs/puppet#7250, this change allows puppet acceptance to pass, as shown here: https://jenkins-master-prod-1.delivery.puppetlabs.net/view/Adhoc/job/platform_puppet-agent-extra_puppet-agent-integration-suite_adhoc-ad_hoc/379/ (pxp-agent continues to fail there, but not at the same setup step as in the first, nightly failure -- pxp-agent will need a separate PR)