A few small puppet helper fixes#97
Merged
Merged
Conversation
There are no puppet collections that use capital letters, so always convert collection parameters to `install_puppet_agent_on` to lowercase.
This is more reliably correct when executing facter on windows where the PATH may not be updated correctly on the SUT.
caseywilliams
force-pushed
the
small-fixes
branch
from
e2605fb to
5c9256b
Compare
Contributor
Author
|
PR tests are still broken, but spec test pass for me locally |
speedofdark
approved these changes
Jan 23, 2019
Contributor
|
Maybe add (maint) to the title :) ? |
Contributor
Author
|
(maint) is in all of the commit messages -- the title on github doesn't affect what goes into the repo |
mcdonaldseanp
approved these changes
Jan 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small commits here:
facterhelper inpuppet_agent_version_on- This seems to be more reliably correct when executing facter on windows where the PATH may not be updated correctly on the SUT.install_puppet_agent_onto lowercase (instead of expecting the caller to get it right -- this is often confusing for PC1/pc1)