(GH-1373,GH-1445) Agent dependent acceptance tests#1641
Merged
lucywyman merged 3 commits intopuppetlabs:masterfrom Feb 27, 2020
Merged
(GH-1373,GH-1445) Agent dependent acceptance tests#1641lucywyman merged 3 commits intopuppetlabs:masterfrom
lucywyman merged 3 commits intopuppetlabs:masterfrom
Conversation
Now that puppet_agent::install can install on fedora31, enable agent dependend acceptance tests.
Contributor
Author
|
Maybe I should split 1d2e2b6 in to two commits, one to delete 10.11 and another add 1015. That way when we get the agent bug sorted out we can just revert. |
Contributor
|
I think in this case it's just as easy to put up a new PR as to revert. Going to merge. |
Given the packages we build bolt for is a subset of puppet agent platforms we should not need to skip any tests targets due to not having an available agent.
…10.15 Until we find a solution for puppetlabs/puppetlabs-puppet_agent#471 , adding macos catalina will not work for agent dependent acceptance tests. Also note we no longer build and test for 10.11.
donoghuc
force-pushed
the
enable-fedora31-agent-dependent-tests
branch
from
1d2e2b6 to
38d7ff5
Compare
Contributor
Author
|
OOps, sorry @lucywyman didnt see your comment tilll after i split out the commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.