(maint) Refactor logic out of Node class#255
Merged
Merged
Conversation
Contributor
Author
|
I was going to roll this into BOLT-292, but that needs a bit more definition and this is ready to go. |
Contributor
Author
|
This should probably wait on #253, as UploadResult will need to be reworked based on that PR. |
|
CLA signed by all contributors. |
MikaelSmith
force-pushed
the
refactor-node
branch
2 times, most recently
from
ab4336b to
7d41739
Compare
Removes the dumb wrappers around run_* from node. Moves logic around upload to a new UploadResult type. Note that the deleted Node tests were mostly redundant with the Result tests.
MikaelSmith
force-pushed
the
refactor-node
branch
from
7d41739 to
7d2338e
Compare
adreyer
approved these changes
Jan 22, 2018
| end | ||
| end | ||
|
|
||
| class UploadResult < Result |
Contributor
There was a problem hiding this comment.
The separate classes are removed in 286
Contributor
Author
There was a problem hiding this comment.
Oh, I thought I removed that code...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the dumb wrappers around run_* from node. Moves logic around upload to a new UploadResult type.
Note that the deleted Node tests were mostly redundant with the Result tests.