Fixed code so hunner/hiera can be pulled from forge #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puppetfile
Outdated
| # Modules from the Puppet Forge | ||
| # Note the versions are all set to :latest but after you've | ||
| # installed you should change them to the exact version you want | ||
| mod "hunner/hiera", :latest |
Contributor
There was a problem hiding this comment.
Can we change this to whatever the current working version is?
If something causes our code here to stop working in a newer version of hunner/hiera I'd like to be pinned to a known good version.
Contributor
Author
|
That's a really good point. I made that change, pointing it to 2.0.1, which is the current forge version. |
Contributor
|
👍 |
natemccurdy
added a commit
that referenced
this pull request
Mar 15, 2016
Fixed code so hunner/hiera can be pulled from forge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I get what is trying to be done with this repo, but there's an incompatibility with the puppetmaster.pp profile if you decide to pull hunner/hiera from the forge instead of github. It's a simple fix, and has been tested on PE 2015.3.1.