Resolve included files before including them #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #95 : substitution inside the file should work without the full path where they are included.
|
CLA signed by all contributors. |
Contributor
|
Ah, sorry I missed this. Can you add a test like https://github.com/puppetlabs/cpp-hocon/blob/master/lib/tests/conf_parser_test.cc#L627-L633 - but with |
Contributor
|
Also, thanks so much for investigating and putting together a fix! |
Contributor
Author
|
This PR does not fix |
Contributor
|
Ah right, that would require a more complex example. |
Contributor
Author
|
Actually the fixtures already had an example pattern I can use. Sent a PR with the test, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95 : substitution inside the file should work without the full
path where they are included.