(PCP-209) Unvendor and rely on installed leatherman #132
Conversation
parisiale
force-pushed
the
PCP-209
branch
3 times, most recently
from
002439f to
e5a5577
Compare
|
LGTM. |
There was a problem hiding this comment.
This seems new, and not something we need.
There was a problem hiding this comment.
Yeah, it's needed by the leatherman 0.3.5 package we're using; its leatherman/lib/cmake/leatherman/LeathermanConfig.cmake includes leatherman_component(curl) which was breaking the build. See https://ci.appveyor.com/project/puppetlabs/cpp-pcp-client/build/1.0.116.
I was planning to get this in and then make a ticket to fix this useless dependency.
Do you have an alternative to fix? Perahps, @branan or @MikaelSmith, I'm doing something wrong.
There was a problem hiding this comment.
Oh, that's a binary artifact of leatherman? I guess we can live with it for now, though we could consider using a source build of leatherman as we do under travis?
There was a problem hiding this comment.
That's a mistake in Leatherman. This PR does use a binary artifact on both platforms, but it's pulling in a required dependency on libcurl even though you're not requesting the Leatherman.curl component. I'll file a ticket to fix it.
|
Looks good, just a minor nit. |
Removing leatherman's git submodule. Updating CMake, Appveyor, and Travis configuration scripts. Updating leatherman's dependency on README.
|
Thanks. I removed the |
(PCP-209) Unvendor and rely on installed leatherman
|
Just for reference, I've created PCP-246 to follow LTH-76. |
4 participants
Removing leatherman's git submodule. Updating CMake, Appveyor, and
Travis configuration scripts. Updating leatherman's dependency on
README.