(PDB-1455) Correct termini install.sh rubylibdir fallback autodetection

[kbarber]

The autodetection routine for AIO pathed Puppet rubylibdir wasn't working.
This showed up when we tried to point our PuppetDB source based tests at a
the ezbake upgrade branch.

This patch adds the Puppet 4/AIO path to PATH when trying to call ruby to
figure out where the terminus belongs.

Signed-off-by: Ken Barber ken@bob.sh

[haus]

@kbarber looks sane enough. are there any other /opt/puppet/bin paths kicking around?

[kbarber]

@haus I'm not sure I understand, do you mean "is /opt/puppet/bin still necessary" or do you mean "any other paths we can throw in here for now". :-).

[haus]

@kbarber i mean did we miss any other uses of /opt/puppet/bin that will break things in a new PE world 😄

[haus]

@kbarber a brief search looks like we're fine here.

[haus]

git grep '/opt/puppet/bin'
resources/puppetlabs/lein-ezbake/template/global/install.sh.erb:    local rubylibdir=${rubylibdir:=$(/opt/puppet/bin/ruby -rrbconfig -e "puts RbConfig::CONFIG['sitelibdir']" 2>/dev/null || ruby -rrbconfig -e "puts RbConfig::CONFIG['sitelibdir']")}

[haus]

i'm 👍 here

[kbarber]

@haus oh I get you ... yeah, I cannot find a thing.