Regression in `os.windows` facts

[joshcooper]

Describe the Bug

Facter 4.5.2 returns the following:

C:\facter>bundle exec facter -j os.windows
{
  "os.windows": {
    "edition_id": "ServerStandard",
    "installation_type": "Server",
    "product_name": "Windows Server 2019 Standard",
    "release_id": "1809",
    "system32": "C:\\Windows\\system32"
  }
}

Facter 4.6.0 returns:

C:\facter>bundle exec facter -j os.windows
{
  "os.windows": {
    "edition_id": 1,
    "installation_type": 1,
    "product_name": 1,
    "release_id": 1,
    "system32": "C:\\Windows\\system32"
  }
}

Expected Behavior

It should return the same values as in facter 4.5.2.

Steps to Reproduce

C:\> cmd /c start /w msiexec /qn /i https://downloads.puppet.com/windows/puppet7/puppet-agent-7.29.0-x64.msi
C:\> "C:\Program Files\Puppet Labs\Puppet\bin\facter" -j os.windows
{
  "os.windows": {
    "edition_id": 1,
    "installation_type": 1,
    "product_name": 1,
    "release_id": 1,
    "system32": "C:\\Windows\\system32"
  }
}

Environment

• Version facter 4.6.0, which is included in both puppet-agent 7.29.0 and 8.5.0
• Platform All Windows

Additional Context

The regression was introduced in 2c291fe#diff-10a200cea4737fabe6bb18f02ff3e23802ec3e6a4526577ac7ae917d1366ddca. The value parameter was misnamed.

[github-actions]

Migrated issue to FACT-3455