(FACT-1144) Add memory resolver for OpenBSD#1074
Merged
peterhuene merged 1 commit intopuppetlabs:masterfrom Aug 3, 2015
jasperla:openbsd/memory
Merged
(FACT-1144) Add memory resolver for OpenBSD#1074peterhuene merged 1 commit intopuppetlabs:masterfrom jasperla:openbsd/memory
peterhuene merged 1 commit intopuppetlabs:masterfrom
jasperla:openbsd/memory
Conversation
|
Mind commenting with the output from the resolver? |
Author
|
There was a problem hiding this comment.
We generally prefer c++-style casts over c-style casts (for various reasons). result.mem_total = static_cast<uint64_t>(uvmexp.npages << uvmexp.pageshift); should do it. Same comment for the line below.
|
Other than above minor comments, this looks good 👍 |
Author
|
I've fixed up the casts and declaration. |
There was a problem hiding this comment.
Looks like this block is unintentionally indented more than needed.
Author
|
That's also fixed now. |
|
@peterhuene, could you take another look now that it's been updated? |
peterhuene
added a commit
that referenced
this pull request
Aug 3, 2015
(FACT-1144) Add memory resolver for OpenBSD
|
@jasperla Thanks again for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently without
swapfacts while those are being sorted out.