Support EC2 facts on OpenStack #126
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenStack exports an EC2 compatible API, so make the information available via facts by knowing that OpenStack generates mac addresses beginning with 02:16:3E
|
@katzj this looks like a straight forward patch. Can you please raise a corresponding Redmine request for this pull request? http://projects.puppetlabs.com/projects/facter Also - if you haven't already, you'll need to ensure you have signed the CLA: https://projects.puppetlabs.com/contributor_licenses/sign Cheers :-). ken. |
|
Done and done -- http://projects.puppetlabs.com/issues/11640 |
|
Now we just need some tests. The test coverage for EC2 is bare at the moment but we have a ticket up for review that should fix that, that you can grow on here: http://projects.puppetlabs.com/issues/11583 Once that is accepted I'll probably ask you to adapt those rspec tests for OpenStack. Is that cool? |
|
Obsoleting this with #139 against 1.6.x and with some tests. |
whopper
pushed a commit
to whopper/facter
that referenced
this pull request
Mar 18, 2015
(CFACT-70) maintenance - refactor usage of kstat to a wrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenStack exports an EC2 compatible API, so make the information
available via facts by knowing that OpenStack generates mac addresses
beginning with 02:16:3E