Support EC2 facts on OpenStack #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to get @bodepd to review this before we merge - the code looks good, includes tests, and is generally awesome. Dan Bode is our local OpenStack expert and I want to make sure this is the best way to identify the platform, etc. Thanks so much for the submission; @katzj, have you filed a ticket in RedMine for this change, and have you signed a CLA? |
|
Yes and http://projects.puppetlabs.com/issues/11583 after @kbarber asked for the exact same thing in the pull request this obsoleted... |
|
@katzj we've changed the ec2 fact quite a bit since this pull request was raised - can you rebase and change your code accordingly? Thanks :-). |
OpenStack exports an EC2 compatible API, so make the information available via facts by knowing that OpenStack generates mac addresses beginning with 02:16:3E
|
sigh Rebased and updated. |
slippycheeze
added a commit
that referenced
this pull request
Jan 23, 2012
Support EC2 facts on OpenStack
whopper
pushed a commit
to whopper/facter
that referenced
this pull request
Mar 18, 2015
(maint) Remove header guards in favor of #pragma once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenStack exports an EC2 compatible API, so make the information
available via facts by knowing that OpenStack generates mac addresses
beginning with 02:16:3E
Update of #126 to be against the 1.6.x branch as the tests don't exist on master.