let facter support ia 11.31 hpux#127
Conversation
add cpu information support to faster support HPUX 11.31 IA64
when server has mc-sg the network card has standby lan card marked with '*' ,when run faster ,it'll show ifconfig no such interface error
|
Hi @huhongbo thanks for the submission. I'm always happy to receive HP-UX improvements to Facter - we have so little contributors from that front so its much appreciated :-). Before we accept it though - can you please raise a Redmine request for this pull request? http://projects.puppetlabs.com/projects/facter Also - if you haven't already, you'll need to ensure you have signed the CLA (we need this before we merge code from any new contributor): https://projects.puppetlabs.com/contributor_licenses/sign Cheers :-). ken. |
|
I'm test puppet and Facter on HP and IBM platform. My and My team will add more feature to these two platform. |
|
G'day @huhongbo. I was hoping you might have a chance to file a redmine ticket for the pull request, and sign the CLA if required, so that we can merge this code? |
|
I have file a redmin ticket for the pull. But It lack the spec test now |
|
Redmine ticket is here: |
There was a problem hiding this comment.
Why are we doing a check here for model =~ /IBM/ - as this throws an error. What was your intention here?
There was a problem hiding this comment.
This is the type mistake,
the Origin line is "if model =~ /IBM/"
just miss the space
There was a problem hiding this comment.
Its not the space per se 'model' just doesn't exist. I guess you just really wanted to tap into the model fact at this point?
In regards to the intention - looks like HP-UX has an lsdev command as well, and that is returning an undesirable response is this correct? Or does this work fine on IBM hardware for HP-UX or something strange like that?
If its an AIX versus HP-UX problem then we should probably check on operatingsystem instead of model. I'm just trying to understand the combinations required for success here, while trying to avoid breaking it for another platform.
There was a problem hiding this comment.
Sorry about that ,I review the code, HP does exist the lsdev ,but it total diff with ibm's lsdev ,IBM AIX Lsdev return the device list ,But HP don't
I try the Let the IBM do the Lsdev and HP do ioscan module
There was a problem hiding this comment.
I'm getting
Error: undefined local variable or method `model' for Facter::Util::Processor:Module
After adding
model = Facter::Util::Resolution.exec('model')
before this line, it seems to work.
|
@mmoll - hey there. Looks like you have used these facts a bit, and added some comments. If they address the issues Ken raised, we would love to bring them in - would you submit a new pull request with the improved version? |
|
@daniel-pittman - sure, but I would like to have pull request #185 handled first, because the changes there are independent from from the ones here. |
|
mmoll has an updated version in #232. Once that is merged, this can be closed. |
6 participants
add cpu information support to facter support HPUX 11.31 IA64