(FACT-1527) Fix Gentoo not reading os release fact correctly#1462
Merged
MikaelSmith merged 1 commit intopuppetlabs:masterfrom Oct 28, 2016
Merged
(FACT-1527) Fix Gentoo not reading os release fact correctly#1462MikaelSmith merged 1 commit intopuppetlabs:masterfrom
MikaelSmith merged 1 commit intopuppetlabs:masterfrom
Conversation
MikaelSmith
reviewed
Oct 28, 2016
| { string(os::oracle_enterprise_linux), string(release_file::oracle_enterprise_linux) }, | ||
| { string(os::oracle_vm_linux), string(release_file::oracle_vm_linux) }, | ||
| { string(os::arista_eos), string(release_file::arista_eos) }, | ||
| { string(os::gentoo), string(release_file::gentoo) }, |
There was a problem hiding this comment.
Looks like this works because the 1st thing we do after is look for the pattern release (\d[\d.]*) in the first line. That matches Gentoo Base System release 2.2, and the rest falls together.
MikaelSmith
approved these changes
Oct 28, 2016
|
Thanks! Looks like that was easy; you've verified it works on your system? |
Contributor
Author
|
Certainly seems that way; |
|
Manually confirmed CLA has been signed. Thanks for the contribution! |
Contributor
Author
|
Happy to help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.