Skip to content

Fix apple rake task#158

Merged
jeffmccune merged 1 commit intopuppetlabs:1.6rcfrom
MosesMendoza:fix_apple_rake_task
Jan 25, 2012
Merged

Fix apple rake task#158
jeffmccune merged 1 commit intopuppetlabs:1.6rcfrom
MosesMendoza:fix_apple_rake_task

Conversation

@MosesMendoza
Copy link
Copy Markdown

....

Signed-off-by: Moses Mendoza moses@puppetlabs.com

…pet.

Signed-off-by: Moses Mendoza <moses@puppetlabs.com>
@MosesMendoza MosesMendoza reopened this Jan 25, 2012
jeffmccune pushed a commit that referenced this pull request Jan 25, 2012
@jeffmccune jeffmccune merged commit 66ca174 into puppetlabs:1.6rc Jan 25, 2012
@jeffmccune
Copy link
Copy Markdown

Moses,

I went ahead and merged this in. It'll make it's way into 1.6.x and master as things get "merged up."

My only comment (I'm a stickler for commit messages) is that in the future please try and use present tense imperative mood. More information on what I mean is at: [Should I use past or present tense in git commit messages?](Should I use past or present tense in git commit messages?) and git - Submitting Patches

As a concrete example for this commit, I would have said:

Replace puppet with facter in apple rake task

Without this patch applied the apple rake task incorrectly uses
identifiers with 'puppet' in them.  This patch fixes the problem by
replacing puppet with facter.

Yes, I know the commit message is longer than the patch, but that's the way it's supposed to be for situations like this... It's not terribly long and it gets to be second nature soon enough.

-Jeff

whopper pushed a commit to whopper/facter that referenced this pull request Mar 18, 2015
(maint) Prevent Ruby's SIGINT handling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants