Fix apple rake task#158
Merged
jeffmccune merged 1 commit intopuppetlabs:1.6rcfrom Jan 25, 2012
MosesMendoza:fix_apple_rake_task
Merged
Fix apple rake task#158jeffmccune merged 1 commit intopuppetlabs:1.6rcfrom MosesMendoza:fix_apple_rake_task
jeffmccune merged 1 commit intopuppetlabs:1.6rcfrom
MosesMendoza:fix_apple_rake_task
Conversation
…pet. Signed-off-by: Moses Mendoza <moses@puppetlabs.com>
|
Moses, I went ahead and merged this in. It'll make it's way into 1.6.x and master as things get "merged up." My only comment (I'm a stickler for commit messages) is that in the future please try and use present tense imperative mood. More information on what I mean is at: [Should I use past or present tense in git commit messages?](Should I use past or present tense in git commit messages?) and git - Submitting Patches As a concrete example for this commit, I would have said: Yes, I know the commit message is longer than the patch, but that's the way it's supposed to be for situations like this... It's not terribly long and it gets to be second nature soon enough. -Jeff |
whopper
pushed a commit
to whopper/facter
that referenced
this pull request
Mar 18, 2015
(maint) Prevent Ruby's SIGINT handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
....
Signed-off-by: Moses Mendoza moses@puppetlabs.com