Skip to content

(#12311) use 'ensure' to restore env vars in Resolution.with_env#166

Closed
cprice404 wants to merge 1 commit intopuppetlabs:masterfrom
cprice404:bug/master/12311-with-env-needs-ensure
Closed

(#12311) use 'ensure' to restore env vars in Resolution.with_env#166
cprice404 wants to merge 1 commit intopuppetlabs:masterfrom
cprice404:bug/master/12311-with-env-needs-ensure

Conversation

@cprice404
Copy link
Copy Markdown

This will make sure that the environment variables get restored to their original values, even if the caller's yield block throws an exception or uses a "return" statement.

This will make sure that the environment variables get restored to their original values, even if the caller's yield block throws an exception or uses a "return" statement.
@kbarber
Copy link
Copy Markdown

kbarber commented Feb 7, 2012

  • Test to prove it fixes the problem would be great.
  • This probably should be targeted at 1.6.x.

@cprice404
Copy link
Copy Markdown
Author

Closing this request because it targets the wrong branch.

@cprice404 cprice404 closed this Feb 8, 2012
whopper pushed a commit to whopper/facter that referenced this pull request Mar 18, 2015
…110-Windows-memory-facts

(CFACT-110) Add Windows memory facts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants