[FACT-1822] Add support for EC2 instances based on the Nitro Hypervisor#1703
Merged
GabrielNagy merged 1 commit intopuppetlabs:2.xfrom Sep 30, 2019
Merged
[FACT-1822] Add support for EC2 instances based on the Nitro Hypervisor#1703GabrielNagy merged 1 commit intopuppetlabs:2.xfrom
GabrielNagy merged 1 commit intopuppetlabs:2.xfrom
Conversation
Collaborator
|
Can one of the admins verify this patch? |
|
CLA signed by all contributors. |
sebastian-miclea
approved these changes
May 22, 2019
|
@puppetcla Can this please get merged as our instances are affected by this patch and we would love to be able to upgrade to a working version? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new Amazon C5 instances are based on the Nitro Hypervisor: https://aws.amazon.com/about-aws/whats-new/2018/01/amazon-ec2-c5-instances-are-now-available-in-us-west--n--california--and-europe--london/
So here is the patch to add support of that instances to the Facter 2.x.
There is another pull-request for this issue (#1700) but it does not cover the Windows instances.