Adds fact about machine's RAID Controller

[LarsFronius]

This adds a small fact to read out machine's raid controllers.
We use it to check RAID Controller on host and install the matching utils.
We also feed our nagios raid check with information from it.

[vholer]

I like more this approach:
https://github.com/kumina/fact-pci_devices/blob/master/pci_devices.rb
This could be easily modified to detect any other devices (RAID, InfiniBand, GPU cards etc.)

I'm commenting on this patch only because I'm solving previous problem (module for nvidia, infiniband etc.) right now and don't want to replicate lspci parsing code between independent modules. I would like to see a generic lspci parsing code in Facter::Util:: reused in a device specific facter libs. (raid.rb, ib.rb etc). This is just my idea, dont' know if it's good approach.

[LarsFronius]

Yeah, that would be nice. The pci_devices.rb is a good start also.

I will take a look if I can start with that Facter::Util thingy! Thanks! The other approach would be a gigantic pci_devices_do_it_all.rb thingy, which nobody wants to see, indead!

[kbarber]

Hi @LarsFronius - thanks for the submission - can you please raise a ticket on this if one doesn't already exist:

http://projects.puppetlabs.com/projects/facter

So we can track the requirement? (versus just the code submission).

You'll need to reference the ticket in any commit messages. Also - be aware that any code we accept will require rspec tests to be added before it can go into core.

[kbarber]

Is this pull request still active @LarsFronius?

[LarsFronius]

Hi and sorry for my late response, we are quite busy right now. I work on a generic fact wrapper around lspci and a puppet module to work with this fact to install the right raid check utilities for your specific raid controller on debian systems.
So yeah, it is basically still active, but I won't mind if one comes up with a solution faster :)

[jeffmccune]

@LarsFronius Thanks for this patch, unfortunately we can't merge it as it currently stands without some automated tests of the expected behavior. Please know that we value the contribution, we're just trying to make sure things that are open are being actively worked on.

Here's my snippet on the subject.

I'm going to go ahead and close this pull request for the time being. Please re-open this pull request once the next actions are addressed, new information is available, or you have a question related to this pull request. We've become aware of difficulties re-opening pull requests, in the event you cannot please mention jeffmccune or adrienthebo with an @ sign in front and we'll re-open this pull request.

Closing the pull request doesn't mean we don't consider this change valuable, just that there are things that need to be addressed before it can be merged. If you have any questions or concerns, please don't hesitate to ping us in #puppet-dev on irc.freenode.net.