Skip to content

(maint) Run tests on facter-ng#1902

Closed
Filipovici-Andrei wants to merge 59 commits intomasterfrom
run_tests_on_ng
Closed

(maint) Run tests on facter-ng#1902
Filipovici-Andrei wants to merge 59 commits intomasterfrom
run_tests_on_ng

Conversation

@Filipovici-Andrei
Copy link
Contributor

No description provided.

@Filipovici-Andrei Filipovici-Andrei requested a review from a team March 26, 2020 10:10
@b4ldr
Copy link
Contributor

b4ldr commented Mar 26, 2020

I'm curious why would you want to do this. this would mean that acceptance test for this project depend on the master branch of an external resource

@mihaibuzgau
Copy link
Contributor

@b4ldr its just for testing, this PR will probably never get merged.

Andrei Filipovici added 3 commits April 10, 2020 12:40
Added a tag to test ticket_1123_facter_with_invalid_locale.rb to see if we can block it when tests are running with facter-ng
Added a tag to test ticket_1123_facter_with_invalid_locale.rb to see if we can block it when tests are running with facter-ng
…on_ng

# Conflicts:
#	acceptance/setup/aio/pre-suite/001_run_with_facter_ng.rb
@puppetcla
Copy link

Waiting for CLA signature by @florindragos

@florindragos - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html

…on_ng

# Conflicts:
#	acceptance/setup/aio/pre-suite/001_run_with_facter_ng.rb
@Filipovici-Andrei Filipovici-Andrei force-pushed the run_tests_on_ng branch 2 times, most recently from ea99351 to 6218c00 Compare May 6, 2020 12:18
@puppetcla
Copy link

CLA signed by all contributors.

@Filipovici-Andrei Filipovici-Andrei deleted the run_tests_on_ng branch July 23, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants