(#14467) Warn when removing relative paths#207
Closed
HAIL9000 wants to merge 3 commits intopuppetlabs:masterfrom
Closed
(#14467) Warn when removing relative paths#207HAIL9000 wants to merge 3 commits intopuppetlabs:masterfrom
HAIL9000 wants to merge 3 commits intopuppetlabs:masterfrom
Conversation
Due to changes made to Facter in commit 634f2f6, Facter no longer looks for facts in relative directories for security reasons. This change could result in users not getting all of their facts. This commit alerts users if a relative directory has been excluded from the search path.
Tests were very noisey on 1.8.7, add Kernel.stubs(:warn) in spec_helper to fix this.
Due to feedback on this pull request on IRC, change message to be debug instead of warn.
|
The short commit log should probably not be identical on all these commits. It should be a short description of what happened in that particular commit. In this case I think you could consider squashing the whole set into one commit. |
|
@pcarlisle Agreed. I explicitly wanted the third commit to be separate because it was based on feedback from @kbarber. I was running off to another meeting and didn't have time to inform @hkenney of the preference in this case for an alterate short commit message. |
|
Manually merged so that I could squash into single commit. |
whopper
pushed a commit
to whopper/facter
that referenced
this pull request
Mar 18, 2015
…117-Windows-networking-facts (CFACT-117) Add Windows networking facts
florindragos
pushed a commit
that referenced
this pull request
Jun 15, 2020
(FACT-2255) Fix filtering for hashed with string keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to changes made to Facter in commit
634f2f6, Facter no longer looks
for facts in relative directories for security reasons. This
change could result in users not getting all of their facts. This
commit alerts users if a relative directory has been excluded from
the search path.