(#14667) Add external cache for facts#236
Closed
HAIL9000 wants to merge 2 commits intopuppetlabs:2.xfrom
Closed
Conversation
Add a shell script which will will send the output of facter to a yaml file, which can serve as an external cache for facts.
|
This script suffers from a simple temp file symlink race condition that any attacker can exploit to overwrite any file on the system owned by the user who runs the script. Please do not merge it. Also we should probably run it with -p. |
bin/external_cache.sh
Outdated
There was a problem hiding this comment.
This file should probably have the "right" extension for the type of content: I would suggest facts.yaml, since "cache" is kind of implicit.
Author
|
@daniel-pittman Thanks for the suggestions. Hopefully the most recent commit will at least address some of the security concerns. |
whopper
added a commit
to whopper/facter
that referenced
this pull request
Mar 18, 2015
…37-restrict-locale (CFACT-137) Restrict Boost.Locale to Windows
florindragos
pushed a commit
that referenced
this pull request
Jun 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a shell script which will send the output of Facter to
a
yamlfile, which can serve as an external cache for facts.