(FACT-1556) Add KVM detection for cloud fact #2475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcooper
reviewed
Feb 3, 2022
cthorn42
force-pushed
the
maint/main/FACT-1556_add_aws_cloud_provider_fact
branch
from
b7d4116 to
0b061f9
Compare
joshcooper
approved these changes
Feb 5, 2022
Contributor
joshcooper
left a comment
joshcooper
left a comment
There was a problem hiding this comment.
LGTM, might be good to install a dev build on linux and windows and confirm facter cloud.provider is what we expect?
cthorn42
force-pushed
the
maint/main/FACT-1556_add_aws_cloud_provider_fact
branch
2 times, most recently
from
896ee65 to
ec8c1f0
Compare
Collaborator
Author
|
Okay with the latest push, I tested both an EL-7 and a Windows Server 2019 on AWS. Ran into an issue where the Windows server had a 'xen' hypervisor. So updated the logic to look for both hypervisors, so I think that should cover us. |
Cloud provider will now detect aws.
cthorn42
force-pushed
the
maint/main/FACT-1556_add_aws_cloud_provider_fact
branch
from
ec8c1f0 to
e15dfcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cloud fact will now detect if the KVM hypervisor is being used and if so look to see which cloud provider is used.