(FACT-3147) Updates minimum Ruby version to 2.5 #2536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I've also updated the branch protection rules to use the Ruby 2.5 version of unit tests instead of Ruby 2.3. |
mhashizume
force-pushed
the
FACT-3147/main/min-ruby-25
branch
from
1e72f68 to
dfa41b9
Compare
This commit replaces all instances in which Ruby 2.3 or 2.4 are referenced with Ruby 2.5 and sets Ruby 2.5 as the minimum Ruby version in the Gemspec and other relevant locations.
Due to increasing the minimum Ruby version to Ruby 2.5, this commit sets the next Facter release version to the next minor/Y version, 4.3.0.
mhashizume
force-pushed
the
FACT-3147/main/min-ruby-25
branch
3 times, most recently
from
b488a45 to
e832c61
Compare
joshcooper
reviewed
Dec 8, 2022
|
|
||
| it 'loads date' do | ||
| pending 'There is a bug in newer versions of Psych and Timecop' if RUBY_VERSION =~ /^3\.2/ | ||
| pending 'There is a bug in newer versions of Psych and Timecop' if RUBY_VERSION.match?(/3.2/) |
Contributor
There was a problem hiding this comment.
Suggested change
| pending 'There is a bug in newer versions of Psych and Timecop' if RUBY_VERSION.match?(/3.2/) | |
| pending 'There is a bug in newer versions of Psych and Timecop' if RUBY_VERSION.to_f == 3.2 && Gem::Version.new(Timecop::VERSION) < Gem::Version.new("0.9.6") |
mhashizume
force-pushed
the
FACT-3147/main/min-ruby-25
branch
3 times, most recently
from
9e8b96c to
56ac1a2
Compare
An issue with earlier versions of timecop caused the 'when yaml contains Date formatted fields' test to fail with the version of Psych included with Ruby 3.2.0. With the release of timecop 0.9.6, this issue has been resolved and we can remove the test from its conditial pending state when that version of timecop is present.
mhashizume
force-pushed
the
FACT-3147/main/min-ruby-25
branch
from
56ac1a2 to
8e9a670
Compare
Contributor
|
Not sure what's up with the acceptance test? Maybe we're expecting 20.04 but |
Contributor
Author
Yeah, looks like you're right: actions/runner-images#6399 I'll put up another commit that just hard codes 20.04 for now |
mhashizume
force-pushed
the
FACT-3147/main/min-ruby-25
branch
from
d591a91 to
8e9a670
Compare
The ubuntu-latest GitHub Actions runner currently translates to Ubuntu 20.04, but will migrate to 22.04 next year: actions/runner-images#6399 Because platform translation is necessary in the presuit.rb file, this commit changes all instances of "ubuntu-latest" in our GitHub Actions configuration to "ubuntu-20.04".
mhashizume
force-pushed
the
FACT-3147/main/min-ruby-25
branch
from
1e078bd to
37d0f59
Compare
Contributor
Author
|
I updated the branch protection rules to reflect the change in the Ubuntu runner. |
joshcooper
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR both updates the minimum Ruby version for Facter to Ruby 2.5 (removing all instances of Ruby 2.3 and 2.4 in the codebase) and increments the next Facter version to 4.3.0.