(FACT-3186) Handle partitions fact when none exist#2575
Merged
joshcooper merged 1 commit intopuppetlabs:mainfrom Jun 6, 2023
Merged
(FACT-3186) Handle partitions fact when none exist#2575joshcooper merged 1 commit intopuppetlabs:mainfrom
joshcooper merged 1 commit intopuppetlabs:mainfrom
Conversation
Contributor
Author
|
Opening as a draft PR until I can do more testing |
Contributor
|
Wondering if these other facts have the same issue: |
972c86d to
752655f
Compare
Contributor
Author
|
@joshcooper I don't think we need to worry about those facts because this should only be an issue with partitions, right? |
Prior to this commit, when a diskless machine used Facter the partitions fact errored out with an undefined method error. This was because the machine did not have any partitions and Facter was unable to dig into the partitions hash because the hash didn't exist. This commit updates Linux's partition fact to return nil early in the partitions method if the partitions resolver returns nothing.
752655f to
1505961
Compare
Contributor
Author
|
After some feedback from the user who reported this issue, I've updated my fix |
Contributor
Author
|
Confirmed with the user in the ticket that this fixes the issue. |
joshcooper
approved these changes
Jun 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, when a diskless machine used Facter the partitions fact errored out with an undefined method error. This was because the machine did not have any partitions and Facter was unable to dig into the partitions hash because the hash didn't exist.
This commit updates Linux's partition fact to return nil early in the partitions method if the partitions resolver returns nothing.