(#20072) Redirect stderr to the correct null device on windows#420
Merged
joshcooper merged 1 commit intopuppetlabs:1.7.xfrom Apr 5, 2013
haus:ticket/1.7.x/20072_fix_virt_what_redirection
Merged
(#20072) Redirect stderr to the correct null device on windows#420joshcooper merged 1 commit intopuppetlabs:1.7.xfrom haus:ticket/1.7.x/20072_fix_virt_what_redirection
joshcooper merged 1 commit intopuppetlabs:1.7.xfrom
haus:ticket/1.7.x/20072_fix_virt_what_redirection
Conversation
Previously the virt_what method redirected stderr to /dev/null, which fails on windows. This commit adds a case for windows where the stderr is redirected to NUL, the windows null device. It also adds tests to ensure this behavior.
|
CLA Signed by haus on 2011-07-19 21:00:00 -0700 |
|
summary: Merged into 1.7.x in commit 18adb84 and released in Facter 1.7.0-rc2 |
florindragos
pushed a commit
that referenced
this pull request
Jun 15, 2020
* (FACt-2498) Load fact from the lowest level of hierarchy first and skip them if they are already loaded. LoadedFacts that are created from aliases or from wilecard facts will have type :legacy. * (FACT-2498) Rubocop fixes. * (FACT-2498) Refactor tests to be compliant with rspec best practices. * (FACT-2498) Add test for creation of LoadedFacts with :legacy and :core types. * (FACT-2498) Add test for wildcard facts. * (FACT-2498) Refactor skipping of already loaded facts. * (FACT-2498) Fix typo. * (FACT-2498) Move class_discoverer_mock in let. * (FACT-2498) Add test to check if legacy fact is a wildcard fact. * (FACT-2498) Extract InternalFactLoader in subject.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the virt_what method redirected stderr to /dev/null, which fails on
windows. This commit adds a case for windows where the stderr is redirected to
NUL, the windows null device. It also adds tests to ensure this behavior.