(#18430) dmidecode: /dev/mem: Operation not permitted in LXC containers

[adedommelin-zz]

No description provided.

[puppetcla]

CLA signed by all contributors.

[adrienthebo]

If this doesn't work on LXC it seems like it would be better to avoid running it at all. Is there a way to bypass this check if /dev/mem is not readable, to save time?

[jasperla]

We're running into the same "issue" on OpenBSD, I'll implement a check for permissions on /dev/mem and skip running dmidecode if we can't read from that device.

[adrienthebo]

I noticed this hasn't seen any activity in about a week. Is there a chance you'll be able to work on this in the coming week? No pressure, just checking in.

[jasperla]

I've fixed the bug in https://github.com/jasperla/facter/commit/dc469b905c02aeba9d2baaf17c938b6282f4cc4b and all regress tests still pass for me. Shall I open a new PR to track that patch?

[adrienthebo]

@jasperla yeah, please open a new PR and we can go from there.

[jasperla]

@adrienthebo Sure thing; I've opened PR 510 to track my patch.

[adrienthebo]

Because this hasn't seen activity in a month and GH-510 has been opened to supercede this, I'm going to go ahead and close this pull request for the time being. Please re-open this pull request once the next actions are addressed, new information is available, or you have a question related to this pull request. We've become aware of difficulties re-opening pull requests, in the event you cannot please mention jeffmccune or adrienthebo with an @ sign in front and we'll re-open this pull request.

Closing the pull request doesn't mean we don't consider this change valuable, just that there are things that need to be addressed before it can be merged. If you have any questions or concerns, please don't hesitate to ping us in #puppet-dev on irc.freenode.net.