(maint) Remove Facter.method_missing#623
Merged
kylog merged 1 commit intopuppetlabs:facter-2from Feb 4, 2014
adrienthebo:maint/facter-2/facter-module-method-missing
Merged
(maint) Remove Facter.method_missing#623kylog merged 1 commit intopuppetlabs:facter-2from adrienthebo:maint/facter-2/facter-module-method-missing
kylog merged 1 commit intopuppetlabs:facter-2from
adrienthebo:maint/facter-2/facter-module-method-missing
Conversation
|
outstanding |
The ability to use method_missing was added in 2006 but was never documented, explained, or generally acknowledge. It was a constant surprise when invoking a non-existent method on Facter would cause all facts to be loaded and possibly a completely nonsensical value would be returned. This commit removes the given code so we can return to a more sane state of affairs.
kylog
pushed a commit
that referenced
this pull request
Feb 4, 2014
…-method-missing (maint) Remove Facter.method_missing
|
CLA signed by all contributors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ability to use method_missing was added in 2006 but was never
documented, explained, or generally acknowledge. It was a constant
surprise when invoking a non-existent method on Facter would cause all
facts to be loaded and possibly a completely nonsensical value would be
returned. This commit removes the given code so we can return to a more
sane state of affairs.