(maint) Return the empty string on exec error#640
Merged
peterhuene merged 1 commit intopuppetlabs:facter-2from Feb 14, 2014
adrienthebo:maint/facter-2/solaris-uptime-error
Merged
(maint) Return the empty string on exec error#640peterhuene merged 1 commit intopuppetlabs:facter-2from adrienthebo:maint/facter-2/solaris-uptime-error
peterhuene merged 1 commit intopuppetlabs:facter-2from
adrienthebo:maint/facter-2/solaris-uptime-error
Conversation
Commit 8a14998 removed most of the special casing around executing commands and changed calling code to always assume that .exec would return a string. However the error cases in .exec would still return nil which would break this assumption. This commit updates .exec to return the empty string on error. It's somewhat questionable to do this but if we want to fail hard on errors we should raise an exception instead of returning nil.
peterhuene
added a commit
that referenced
this pull request
Feb 14, 2014
…e-error (maint) Return the empty string on exec error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 8a14998 removed most of the special casing around executing
commands and changed calling code to always assume that .exec would
return a string. However the error cases in .exec would still return
nil which would break this assumption.
This commit updates .exec to return the empty string on error. It's
somewhat questionable to do this but if we want to fail hard on errors
we should raise an exception instead of returning nil.