Skip to content

Fact 650 operatingsystemmajrelease supports suse#757

Closed
ghoneycutt wants to merge 3 commits intopuppetlabs:masterfrom
ghoneycutt:fact-650-operatingsystemmajrelease_supports_suse
Closed

Fact 650 operatingsystemmajrelease supports suse#757
ghoneycutt wants to merge 3 commits intopuppetlabs:masterfrom
ghoneycutt:fact-650-operatingsystemmajrelease_supports_suse

Conversation

@ghoneycutt
Copy link

No description provided.

@ghoneycutt
Copy link
Author

Left these as separate commits, though happy to rebase and squash.

This was done without access to a Suse system and as such should be tested on an actual system before merging.

@philippvh
Copy link

Did a quick file-replace-test on SLES11 SP3 and SLES10 SP4. Looks good:

$ facter operatingsystemrelease
11.3
$ facter operatingsystemmajrelease
11

@jpartlow
Copy link

@ghoneycutt thanks for the contributions. Would you update the two maintenance commit messages with '(maint)' and this should be good to go.

@whopper
Copy link

whopper commented Aug 13, 2014

@ghoneycutt @jpartlow on a related note, the new implementation of the operatingsystem structured fact also makes this same change. It is currently being reviewed / tested and should be merged in the next few days at the latest.

@ghoneycutt
Copy link
Author

@jpartlow Got it.

@philippvh Thanks for jumping in the with testing!!

@whopper
Copy link

whopper commented Aug 18, 2014

@ghoneycutt with today's merging of the operatingsystem structured fact (c0812a8), this functionality has been added into Facter, so I'm going to go ahead and close this PR.

Thanks a ton for all of your contributions - we very much appreciate them!

@whopper whopper closed this Aug 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants