report when we have skipped "bad definition in :hierarchy"#360
Merged
branan merged 1 commit intopuppetlabs:masterfrom Aug 23, 2016
Merged
report when we have skipped "bad definition in :hierarchy"#360branan merged 1 commit intopuppetlabs:masterfrom
branan merged 1 commit intopuppetlabs:masterfrom
Conversation
Contributor
|
This seems pretty reasonable. The CI failure is looking for the commit message to match our style guidelines in https://github.com/puppetlabs/hiera/blob/master/CONTRIBUTING.md#making-changes. |
Author
|
Ok I updated the commit message but seem to have got a merge in there too! |
Hiera tests its hierarchy sources list to make sure they do not contain a known pattern that will break a file path. If a known bad patern is found the source is silently dropped. Adding this patch will cause Hiera to generate a warning as well as dropping the source. This new functionality will help users debug bad Hiera configuration.
Author
|
18th time better ;) |
Contributor
|
Thanks for your contribution, @DrOwl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per discussion in Puppetlabs git ticket HI-530
report when we have skipped "bad definition in :hierarchy"